- All Implemented Interfaces:
- KubernetesToOpenShiftConverter
public class DeploymentConfigOpenShiftConverter
extends Object
implements KubernetesToOpenShiftConverter
Takes a DeploymentConfig generated from a vanilla Deployment as part of the aggregation
and enriches it with the timeout.
See discussions about the timeout : https://github.com/openshift/origin/issues/10531
-- Discussion --------------------------------------------------------------------------------------------
roland: in fact, this is the wrong place for adapting an OpenShit object (or 'converting an OpenShift object
to an OpenShift object'), as the converters only purpose should be to *convert* Kubernetes to OpenShift objects.
This here looks like it should go into an enricher. I know, that the enriching phase happens before the
conversion phase, so deployment configs which were created on behalf of a conversion from
Deployment -> DeploymentConfig wont be enriched anymore.
There are two solutions to get rid of this converter:
* Add an enricher for regular DeploymentConfigs provided by an user to add this timeout. Drawback: Timeout would
be needed to configured twice
* Add a second enrich phase after conversion to OpenShift objects.
------------------------------------------------------------------------------------------------------------